UNCLASSIFIED - NO CUI

Skip to content

Update regex to more explicitly follow headers

Daniel Dides requested to merge dd/fix-upgrade-notice-parsing into master

General MR

Summary

@dhilgaertner2 found an issue where the Upgrade Notices parsing regex was less flexible than it needed to be.

## Upgrade Notices #### Breaking Changes from 8.12.0 release notes (kibana) - New SLO architecture - A new sub-feature privilege to control user access to the cases settings

Was tripping up the regex as it was looking for all the text between ## Upgrade Notices and another ##. The #### was matching this end parameter causing the regex to cancel early and return no results.

This change should make it more strictly look for just two # symbols.

Relevant logs/screenshots

Before:

 ./test.sh
Validating Big Bang Merge Request
Requesting https://repo1.dso.mil/api/v4/projects/big-bang%2Fproduct%2Fpackages%2Felasticsearch-kibana/merge_requests/177
This MR contains the following updates: | Package | Update | Change | |---|---|---| | gluon | patch | `0.4.6` -> `0.4.7` | | [registry1.dso.mil/ironbank/elastic/elasticsearch/elasticsearch](https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch) | minor | `8.11.3` -> `8.12.0` | | [registry1.dso.mil/ironbank/elastic/kibana/kibana](https://repo1.dso.mil/dsop/elastic/kibana/kibana7) | minor | `8.11.3` -> `8.12.0` | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox. --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Source: https://www.elastic.co/guide/en/kibana/current/release-notes-8.12.0.html ## Upgrade Notices #### Breaking Changes from 8.12.0 release notes (kibana) - New SLO architecture - A new sub-feature privilege to control user access to the cases settings

Invalid value for Upgrade Notices: 

After:

./test.sh
Validating Big Bang Merge Request
Requesting https://repo1.dso.mil/api/v4/projects/big-bang%2Fproduct%2Fpackages%2Felasticsearch-kibana/merge_requests/177
This MR contains the following updates: | Package | Update | Change | |---|---|---| | gluon | patch | `0.4.6` -> `0.4.7` | | [registry1.dso.mil/ironbank/elastic/elasticsearch/elasticsearch](https://repo1.dso.mil/dsop/elastic/elasticsearch/elasticsearch) | minor | `8.11.3` -> `8.12.0` | | [registry1.dso.mil/ironbank/elastic/kibana/kibana](https://repo1.dso.mil/dsop/elastic/kibana/kibana7) | minor | `8.11.3` -> `8.12.0` | --- ### Configuration 📅 **Schedule**: At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 👻 **Immortal**: This MR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, click this checkbox. --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). Source: https://www.elastic.co/guide/en/kibana/current/release-notes-8.12.0.html ## Upgrade Notices #### Breaking Changes from 8.12.0 release notes (kibana) - New SLO architecture - A new sub-feature privilege to control user access to the cases settings
here
one: 
#### Breaking Changes from 8.12.0 release notes (kibana)

- New SLO architecture
- A new sub-feature privilege to control user access to the cases settings
two: 
#### Breaking Changes from 8.12.0 release notes (kibana)

- New SLO architecture
- A new sub-feature privilege to control user access to the cases settings
three: "#### Breaking Changes from 8.12.0 release notes (kibana) - New SLO architecture - A new sub-feature privilege to control user access to the cases settings"
four: #### Breaking Changes from 8.12.0 release notes (kibana) - New SLO architecture - A new sub-feature privilege to control user access to the cases settings
here
#### Breaking Changes from 8.12.0 release notes (kibana) New SLO architecture A new subfeature privilege to control user access to the cases settings

Upgrade Notices: #### Breaking Changes from 8.12.0 release notes (kibana) New SLO architecture A new subfeature privilege to control user access to the cases settings

Linked Issue

No issue, bugfix

Upgrade Notices

N/A

Merge request reports