Use of enable/disable instead of expected true/false in istio.injection binary key.
Summary
the istio.injection key takes an enable/disable value instead of the expected true/false convention. This results in what I'd consider a UX bug because it doesn't work the way I expect from working with other helm charts and even the istio.enabled or any other true/false values for keys in the rest of this very chart. This forces me to go read the docs for which words are used and then remember it is "enable" or "enabled". This causes needless churn.
Steps to reproduce
See documentation on istio.injection: https://repo1.dso.mil/platform-one/big-bang/apps/security-tools/anchore-enterprise/-/blob/main/README.md#L40
What is the current behavior?
Uses enable/disable for a binary key.
What is the expected behavior?
Use of true/false for binary keys.
Relevant logs and/or screenshots
anchore-engine/templates/bigbang/sso/configure-sso.yaml:56:21: executing "anchore-engine/templates/bigbang/sso/configure-sso.yaml" at <eq .Values.istio.injection "enabled">: error calling eq: incompatible types for comparison
Possible fixes
Change istio.injection to use true/false or support true as enabled and false as disabled.