Fix upgrade job
The argocd upgrade job was failing in Big Bang CI
Needed to remove the .Values.istio.injection
from the conditional wrapped around the logic for killing the istio sidecar container
This value isn't present in the argocd chart, and was causing it to not render out and execute, causing the istio sidecar to stick around and the job to not complete, causing the helm release to fail.
Here's the pipeline now with the job running and terminating successfully - https://repo1.dso.mil/platform-one/big-bang/bigbang/-/pipelines/1084410
Edited by Lucas Rodriguez