Chart refactor for passthrough + redis-bb
General MR
Summary
- move
global
to top level yaml structure (required for upstream helpers templating) - move
redis-bb
to top level yaml structure - remove SSO config as it is baked in from upstream umbrella values (see changes: big-bang/bigbang!6528 (diffs))
^ note: these will be integrated into the argocd bb.2 tag as changes upstream. Current SSO values are utilized in bigbang umbrella
addons.argocd.sso
section, and should not be affected.
Relevant logs/screenshots
test AWS credentials propagation to repo-server (utilizing addons.argocd.values.awsCredentials
block):
sso login/confirmation flow working:
Linked Issue
Upgrade Notices
- Refactoring package with passthrough pattern. Passing values to the argoCD upstream chart will require an additional layer of overlay:
addons.argocd.values.upstream
An example for update would look like the following:
Current Values
configs:
cm:
oidc.config: |
name: keycloak
...
Updated Values
upstream:
configs:
cm:
oidc.config: |
name: keycloak
...
This change does not apply to bigbang specific values in the chart, i.e. awsCredentials
, istio
, monitoring
, networkPolicies
, upgradeJob
, bbtests
, openshift
, and redis-bb
. Note that global
is also preserved due to an upstream requirement.
- SSO is now propagated through the proper
values.yaml
channels in upstream argocd chart. Users should refer to upstream chart for any additional SSO configuration, specificallyargo-cd/templates/argocd-configs/argocd-rbac-cm.yaml
andargo-cd/templates/argocd-configs/argocd-cm.yaml
found here.
Edited by Chris Schaefer