Double quote bug fix for jwks_uri
When running this chart today, I received this error (this is without the quotes even, although the umbrella chart in the BB main repo, says to use quotes).
[2023-04-24 20:16:07.746] [console] [error] main: Unexpected error: Expected , or } after key:value pair.
"jwks_uri": ""https://keycloak.big
^
How this is reproduced:
addons:
authservice:
enabled: true
chains:
full:
...
jwks_uri: https://keycloak.bigbang.dev/auth/realms/baby-yoda/protocol/openid-connect/certs
Merge request reports
Activity
requested review from @micah.nagel, @ryan.j.garcia, and @rob.ferguson
assigned to @danny-radiusmethod
It does look like this would lead to double quotes since
| quote
wraps output in double-quotes but I am unable to reproduce through BigBang or templating the chart.For BB using: global: oidc: host: login.dso.mil realm: baby-yoda jwks_uri: "https://login.dso.mil/auth/realms/baby-yoda/protocol/openid-connect/certs" ...
--- # Source: authservice/templates/secret.yaml apiVersion: v1 kind: Secret metadata: name: authservice namespace: default stringData: config.json: | { ..., "default_oidc_config": { "authorization_uri": "https://login.dso.mil/auth/realms/baby-yoda/protocol/openid-connect/auth", "token_uri": "https://login.dso.mil/auth/realms/baby-yoda/protocol/openid-connect/token", "jwks_fetcher": { "jwks_uri": "https://login.dso.mil/auth/realms/baby-yoda/protocol/openid-connect/certs", "periodic_fetch_interval_sec": 60, "skip_verify_peer_cert": "false" },
Yes this is because
default_oidc_config
renders differently in the chart. https://repo1.dso.mil/big-bang/product/packages/authservice/-/blob/main/chart/templates/secret.yaml#L31Versus
oidc_override
as part ofchains
(I probably should have been more specific in my ticket explaining how it was set, but I will update the description.)This was helpful though, because I probably don't need to override and can get around this with the global. But the bug is still there.
- Resolved by Danny Gershman
- Resolved by Ryan Garcia
Can we merge this?
added authservice kindbug statusreview labels
changed milestone to %2.4.0
mentioned in commit 6529a4c7
mentioned in merge request big-bang/bigbang!2823 (merged)