Tweaks flaking log timing tests from 'assert after' to 'assert not before'
General MR
Summary
@daniel.dides identified an odd test flakiness problem that shows up a lot more in go
1.23.1
on our ARM Macs than it does in go
1.22.x
. Sixteen tests were asserting that a logging operation took a nonzero amount of measurable time, and that no longer seems to be the case.
This MR flips the tests from "assert that log time is after start time" to "assert that log time is not before start time" and now those tests aren't failing, even when rerun hundreds of times.
Relevant go release notes
@daniel.dides found some relevant release notes for go
1.23
on changing the behavior of timers.
Relevant logs/screenshots
--- FAIL: TestLogPass (0.00s)
client_functions_test.go:277:
Error Trace: /Users/daniel/radius/bb/bbctl/util/log/client_functions_test.go:277
Error: Should be true
Test: TestLogPass
Messages: logtime: 2024-09-09 09:00:37.416012 -0500 CDT startTime: 2024-09-09 09:00:37.416012 -0500 CDT
Linked Issue
N/A
Upgrade Notices
N/A
Edited by Daniel Pritchett