Fix Subchart Label Parsing

General MR

Summary

Fixes a parsing error in the prometheus subchart.

Big Bang test MR: big-bang/bigbang!4972 (diffs)

* Deployment.apps "logging-ek-metrics" is invalid: spec.template.labels: Invalid value: "{{ .Chart.AppVersion }}": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue', or 'my_value', or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')

I added a conditional to handle if no extra pod labels are supplied, and also noticed that the tgz'd copy of the subchart was out-of-sync with the copy of the subchart in the deps folder, and the older version contained the bug, so i re-ran helm dependency update to get them back in sync.

Relevant logs/screenshots

Confirmed that kibana installs now, the error is gone.

https://repo1.dso.mil/big-bang/bigbang/-/jobs/37780568#L5426

Linked Issue

issue

Upgrade Notices

N/A