SKIP UPGRADE Update Ironbank to v15.4.0

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [0.45.0-bb.0] - 2022-10-11
+### Updated
+- Update helm chart to v0.45.0 app version 15.4.0 
+
 ## [0.44.0-bb.0] - 2022-09-26
 ### Updated
 - Update helm chart to v0.44.0 app version 15.3.0 

README.md

 # gitlab-runner
 
-![Version: 0.44.0-bb.0](https://img.shields.io/badge/Version-0.44.0--bb.0-informational?style=flat-square) ![AppVersion: 15.3.0](https://img.shields.io/badge/AppVersion-15.3.0-informational?style=flat-square)
+![Version: 0.45.0-bb.0](https://img.shields.io/badge/Version-0.45.0--bb.0-informational?style=flat-square) ![AppVersion: 15.4.0](https://img.shields.io/badge/AppVersion-15.4.0-informational?style=flat-square)
 
 GitLab Runner
 
@@ -40,9 +40,6 @@ helm install gitlab-runner chart/
 | repository | string | `"ironbank/gitlab/gitlab-runner/gitlab-runner"` |  |
 | tag | string | `"v15.3.0"` |  |
 | imagePullPolicy | string | `"IfNotPresent"` |  |
-| probeTimeoutSeconds | int | `1` |  |
-| replicas | int | `1` |  |
-| revisionHistoryLimit | int | `10` |  |
 | gitlabUrl | string | `"http://gitlab-webservice-default.gitlab.svc.cluster.local:8181"` |  |
 | terminationGracePeriodSeconds | int | `3600` |  |
 | concurrent | int | `50` |  |
@@ -79,7 +76,7 @@ helm install gitlab-runner chart/
 | securityContext.runAsNonRoot | bool | `true` |  |
 | securityContext.privileged | bool | `false` |  |
 | securityContext.capabilities.drop[0] | string | `"ALL"` |  |
-| podSecurityContext.runAsUser | int | `100` |  |
+| podSecurityContext.runAsUser | int | `1001` |  |
 | podSecurityContext.fsGroup | int | `65533` |  |
 | containerSecurityContext.capabilities.drop[0] | string | `"ALL"` |  |
 | resources.limits.memory | string | `"256Mi"` |  |

chart/CHANGELOG.md

+## v0.45.0 (2022-09-21)
+
+### New features
+
+- Update GitLab Runner version to 15.4.0
+- Add secrets update permission to RBAC example provided !349 (Tim Hobbs @hobti01)
+
+### Bug fixes
+
+- Revert "Merge branch 'feature/unregister-one-runner' into 'main'" !362
+
+### Maintenance
+
+- Fix the pipeline being blocked by development release !357
+- Docs: Update values.yaml comments to reference kubernetes service accounts docs !310
+
 ## v0.44.0 (2022-08-19)
 
 ### New features

chart/Chart.yaml

 apiVersion: v1
 name: gitlab-runner
-version: 0.44.0-bb.0
-appVersion: 15.3.0
+version: 0.45.0-bb.0
+appVersion: 15.4.0
 description: GitLab Runner
 keywords:
 - git
@@ -16,8 +16,8 @@ maintainers:
   email: support@gitlab.com
 annotations:
   bigbang.dev/applicationVersions: |
-    - Gitlab Runner: v15.3.0
+    - Gitlab Runner: v15.4.0
 dependencies:
   - name: gluon
-    version: 0.2.9
+    version: 0.3.1
     repository: oci://registry.dso.mil/platform-one/big-bang/apps/library-charts/gluon

chart/Kptfile

@@ -5,7 +5,7 @@ metadata:
 upstream:
   type: git
   git:
-    commit: 49a3f1cdd30cf288bcadfa190382b2253f1aad65
+    commit: ab2d6bdb09dfbed16e339a49d376713e1ceb09f6
     repo: https://gitlab.com/gitlab-org/charts/gitlab-runner
     directory: /
-    ref: v0.44.0
+    ref: v0.45.0

chart/requirements.lock

 dependencies:
 - name: gluon
   repository: oci://registry.dso.mil/platform-one/big-bang/apps/library-charts/gluon
-  version: 0.2.9
-digest: sha256:0cec9e7b386efbd3bacb900b3ec768477f9c5a24992ee82fb862d1d8abe9ebd0
-generated: "2022-04-26T13:28:50.089248-06:00"
+  version: 0.3.1
+digest: sha256:fad55ec6764b642d9359d703a89979f0ab5a955a48d04774b4d30004a14d4f7c
+generated: "2022-10-11T12:18:00.058321729-06:00"

chart/templates/_helpers.tpl

@@ -89,19 +89,7 @@ Define the server session external port, using 8093 as a default value
 {{- end -}}
 
 {{/*
-Unregister runner on pod stop
-*/}}
-{{- define "gitlab-runner.unregisterRunner" -}}
-{{- if or (and (hasKey .Values "unregisterRunner") .Values.unregisterRunner) (and (not (hasKey .Values "unregisterRunner")) .Values.runnerRegistrationToken) -}}
-lifecycle:
-  preStop:
-    exec:
-      command: ["/entrypoint", "unregister", "--config=/home/gitlab-runner/.gitlab-runner/config.toml"]
-{{- end -}}
-{{- end -}}
-
-{{/*
-Unregister all runners on pod stop
+Unregister runners on pod stop
 */}}
 {{- define "gitlab-runner.unregisterRunners" -}}
 {{- if or (and (hasKey .Values "unregisterRunners") .Values.unregisterRunners) (and (not (hasKey .Values "unregisterRunners")) .Values.runnerRegistrationToken) -}}

chart/templates/deployment.yaml

@@ -51,7 +51,6 @@ spec:
         securityContext:
           allowPrivilegeEscalation: false
           {{- toYaml $.Values.containerSecurityContext | nindent 10 }}
-        {{- include "gitlab-runner.unregisterRunner" . | nindent 8 }}
         {{- include "gitlab-runner.unregisterRunners" . | nindent 8 }}
         command: ["/bin/bash", "/configmaps/entrypoint"]
         env:

chart/tests/cypress/02-gitlab-signup.spec.js

+Cypress.on('uncaught:exception', (err, runnable) => {
+  // returning false here prevents Cypress from
+  // failing the test
+  if (err.message.includes('Cannot read')) {
+    return false
+  }  
+})
+
 describe('Gitlab Signup', () => {
   it('Check user is able to signup', () => {
     // test signup
     cy.visit('/users/sign_up')
+
     cy.get('input[id="new_user_first_name"]').type(Cypress.env('gitlab_first_name'))
     cy.get('input[id="new_user_last_name"]').type(Cypress.env('gitlab_last_name'))
     cy.get('input[id="new_user_username"]').type(Cypress.env('gitlab_username'))

chart/tests/cypress/03-gitlab-login.spec.js

+Cypress.on('uncaught:exception', (err, runnable) => {
+  // returning false here prevents Cypress from
+  // failing the test
+  if (err.message.includes('Cannot read')) {
+    return false
+  }  
+})
 
 describe('Gitlab Login', () => {
   it('Check admin is able to login', () => {

chart/tests/cypress/04-gitlab-create-project.spec.js

@@ -38,4 +38,4 @@ describe('Create Gitlab Project', () => {
     })
 
   })
-})
+})
\ No newline at end of file

chart/values.yaml

@@ -15,7 +15,7 @@
 image: null
 registry: registry1.dso.mil
 repository: ironbank/gitlab/gitlab-runner/gitlab-runner
-tag: v15.3.0
+tag: v14.4.0
 
 ## Specify a imagePullPolicy for the main runner deployment
 ## 'Always' if imageTag is 'latest', else set to 'IfNotPresent'
@@ -64,18 +64,6 @@ gitlabUrl: http://gitlab-webservice-default.gitlab.svc.cluster.local:8181
 # runnerToken: ""
 #
 
-## Unregister runner before termination
-##
-## Updating the runner's chart version or configuration will cause the runner container
-## to be terminated and created again. This may cause your GitLab instance to reference
-## non-existant runners. Un-registering the runner before termination mitigates this issue.
-## ref: https://docs.gitlab.com/runner/commands/index.html#gitlab-runner-unregister
-##
-## Please set unregisterRunners to false if you set unregisterRunner to true as only
-## one preStop action is supported.
-##
-# unregisterRunner: true
-
 ## Unregister all runners before termination
 ##
 ## Updating the runner's chart version or configuration will cause the runner container
@@ -329,7 +317,7 @@ runners:
   helper:
     registry: registry1.dso.mil
     repository: ironbank/gitlab/gitlab-runner/gitlab-runner-helper
-    tag: "v15.3.0"
+    tag: "v14.4.0"
 
   # runner configuration, where the multi line strings is evaluated as
   # template so you can specify helm values inside of it.

docs/DEVELOPMENT_MAINTENANCE.md

@@ -8,6 +8,7 @@ BigBang makes modifications to the upstream helm chart. The full list of changes
 1. Look in ```/chart/Chart.yaml``` at the dependencies and verify that you have the most recent version of the [Bigbang Gluon](https://repo1.dso.mil/platform-one/big-bang/apps/library-charts/gluon/-/tags) library. If not, delete the ```/chart/charts/gluon-x.x.x.tgz``` file and the ```/requirements.lock``` file. You will replace these files in the next step.
 1. Run a helm dependency command to update the chart/charts/*.tgz archives and create a new requirements.lock file. You will commit the tar archives along with the requirements.lock that was generated.
     ```bash
+    export HELM_EXPERIMENTAL_OCI=1
     helm dependency update ./chart
     ```
 1. In ```/chart/values.yaml``` update all the gitlab image tags to the new version. There are 3 images: gitlab-runner, gitlab-runner-helper, and the ubi.

tests/images.txt

-registry1.dso.mil/ironbank/gitlab/gitlab-runner/gitlab-runner-helper:v15.2.1
+registry1.dso.mil/ironbank/gitlab/gitlab-runner/gitlab-runner-helper:v15.4.0
 registry1.dso.mil/ironbank/redhat/ubi/ubi8:8.6