Community contribution PR-6

General MR

Summary

This change updates the NetworkPolicy resources to match the deployed gitlab runner pods using their full name instead of the hard-coded app: gitlab-runner label.

Reasoning behind the change: Matching on the fullname allows the chart to be used to simultaneously deploy multiple instances of the Gitlab Runner.

Relevant logs/screenshots

See Comments

Linked Issue

issue

Upgrade Notices

N/A

Github Comment Mirrored Here

P1-Bot commented:

---

Thank You!

Your contribution to the DSO Repo1 has been mirrored to !211 (merged)

Current features

1. Comments will be mirrored to the associated GitLab Merge Request.
2. Quote Replies will mirror to Gitlab as a Thread
3. Updates to code will be pushed to the associated GitLab Merge Request.
4. Closing the PR will close the associated GitLab Merge Request.

Features not available yet

1. Comments on code will not be mirrored

Thanks Travis, I'll pass this along to the Dev+Ops mission team here at BigBang.

added community-contribution teamDevelopment & Ops labels

Pushed to bugfix/network-policies-pod-labels branch in Github

@group_3988_bot_8ac6b4ba8950cff3a8baf9adec719973 This merge request is not marked as draft, if it is ready for review please add the label, statusreview.

added needs-labels label

added statusreview label

Pushed to bugfix/network-policies-pod-labels branch in Github

assigned to @matt.vasquez

Pushed to bugfix/network-policies-pod-labels branch in Github

Is there anyway to get this prioritized, we at CNAP / P1ES currently have to install the runners outside of BB chart and use IB images. It would be great to consolidate those out of band deployments inside BB

Big Bang's integration team also has a customer that will need this soon.

@group_3988_bot_8ac6b4ba8950cff3a8baf9adec719973 this merge request has been inactive for 30 days and is being labelled as stale. If this merge request is still required please take action by removing the stale label and commenting with an update, status, or justification. If this merge request is not required please close it or label it as delete-me. If no action is taken this merge request will be auto closed in 60 days.

added stale label

This has been open for a long time, and is a really simple change to enable multiple instances of this chart in a single cluster, which is a very normal thing to do for gitlab runners. Could we please have someone take a look at this? It would be great to have it merged.

removed stale label

requested review from @alieberman

approved this merge request

marked this merge request as draft