SKIP UPGRADE Resolve "Re-evaluate test-values.yaml"
General MR
Summary
Remove duplicate values present in test-values.yaml that are already present in default values.yaml
Relevant logs/screenshots
N/A
Linked Issue
Upgrade Notices
N/A
Closes #274 (closed)
Edited by Matt Vasquez
Merge request reports
Activity
added kindmaintenance priority6 teamDevelopment & Ops labels
assigned to @alfredodiaz53
added statusdoing label
added 1 commit
- c79b1be8 - remove duplicate defaulted overrides from test-values.yaml
assigned to @matt.vasquez and unassigned @alfredodiaz53
added 1 commit
- fd0e3359 - correct removing duplicates from test-values.yaml
added 13 commits
-
0f81bb96...fd67855a - 12 commits from branch
main
- c3f5fc51 - Merge branch 'main' into '274-re-evaluate-test-values-yaml'
-
0f81bb96...fd67855a - 12 commits from branch
For Reviewer:
Here is a check you can do to check for duplicate between test-values and ./chart/values.yaml:
comm -1 -2 \ <(yq -P 'sort_keys(..)' -o=props <(curl -s https://repo1.dso.mil/big-bang/product/packages/gitlab/-/raw/main/chart/values.yaml) | sort) \ <(yq -P 'sort_keys(..)' -o=props <(curl -s https://repo1.dso.mil/big-bang/product/packages/gitlab/-/raw/274-re-evaluate-test-values-yaml/tests/test-values.yml) | sort) \ | sed '/^$/d'
output should be empty if no duplicates are detected.
Edited by Matt Vasquezmentioned in commit 8e60b5ea
mentioned in merge request big-bang/bigbang!5183 (closed)
changed milestone to %2.38.0
added statusreview label and removed statusdoing label
Please register or sign in to reply