harbor update

General MR

Summary

Updated the values.yaml file to include default values for annotations and imagePullSecret

Relevant logs/screenshots

(Include any relevant logs/screenshots)

Linked Issue

issue

Upgrade Notices

N/A

added teamDevelopment & Ops label

@ayo.ogunfeitimi This merge request is not marked as draft, if it is ready for review please add the label, statusreview.

added needs-labels label

marked this merge request as draft

added 17 commits

• 7265ee4c...0f1db2f2 - 16 commits from branch main
• c2e4965a - Pulling in daily changes from master to my test branch

Compare with previous version

added 2 commits

• c826bdd4 - "Updated values.yaml with dfault value for annotations and imagePullSecret"
• edd0d29c - "Updated README.md"

Compare with previous version

marked this merge request as ready

requested review from @alfredodiaz53, @daniel.stocum, and @matt.vasquez

added statusdoing label

removed needs-labels label

changed the description

added statusreview label and removed statusdoing label

mentioned in merge request big-bang/bigbang!5205 (closed)

requested review from @afarasoteemo, @nbazzeghin, and @cschaefer

changed the description

whoever does the work, recommend testing and uploading evidence that the registry deployment is properly using the service account and that annotations can be passed to the service account. Please don't approve or merge without evidence of that validation on the MR.

assigned to @ayo.ogunfeitimi

changed milestone to %2.38.0

changed milestone to %2.39.0

changed milestone to %2.40.0

added 4 commits

• edd0d29c...f9589c22 - 2 commits from branch main
• a3a15999 - resolving issue on helper template file
• 37b718b1 - Merge branch 'service_account' of...

Compare with previous version

added 1 commit

• fac311fd - Creating a default for serviceAccountName

Compare with previous version

added 1 commit

• 3b6fa2bd - declaring if_statement for registry service Account

Compare with previous version

requested review from @cnowicki

added 1 commit

• 6273e6b5 - address default value for serviceAccount annotations

Compare with previous version

added 1 commit

• 369ce83f - removing unwanted commented code line

Compare with previous version

added 1 commit

• 7b76e8e8 - resolving lint issue on contributing doc

Compare with previous version

Screenshots of successful deployment shown below.

requested review from @afarasoteemo

resolved all threads

@afarasoteemo can you validate with a test annotation to confirm annotations are propagating to the registry deployment? anything works, like a test: succeeded or otherwise. Also, some clarity on CHANGELOG.md, I don't see the mentioned resources from the changelog.

Screenshot verifying annotation setting for the service account is applied.

added 1 commit

• c796141a - updating changelog and readme files

Compare with previous version

requested review from @afarasoteemo

resolved all threads

@afarasoteemo there are merge conflicts, also can you elaborate on the serviceaccount-server.yaml noted in changelog? i do not see it in the diff

added 2 commits

• 2a01796a - updating changelog file
• 04862137 - resolving conflicts

Compare with previous version

added 1 commit

• fc8edd26 - reversing conflict resolution

Compare with previous version

it looks like a greater part of this work has already been merged so instead of using the same branch. A new branch should have been created to resolve outstanding issues. I will close this MR and create a new branch from main to resolve the outstanding issue. Please see image of previous merge below

closed