fix(values): added `istio=ingressgateway` to default `upstream.labels`

General MR

Summary

This MR fixes an issue with the default values of istio-gateway not matching up with the expectations in the clean-install pipeline that runs on merges. The pipeline gets all services from the cluster with a label istio=ingressgateway to determine which namespace contains the gateways. By adding this label to the default values, we can ensure the pipeline runs successfully.

Relevant logs/screenshots

Before

❯ helm template istio-gateway ./chart | yq 'select(.kind == "Service")'

# Source: gateway/charts/upstream/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: istio-gateway
  namespace: default
  labels:
    app.kubernetes.io/name: istio-gateway
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "istio-gateway"
    app.kubernetes.io/part-of: "istio"
    app.kubernetes.io/version: "1.25.1"
    helm.sh/chart: upstream-1.25.1
    app: istio-gateway
    istio: gateway
    "istio.io/dataplane-mode": "none"
  annotations: {}
spec:
  type: LoadBalancer
  ports:
    - name: tcp-status-port
      port: 15021
      protocol: TCP
      targetPort: 15021
    - name: http2
      port: 80
      protocol: TCP
      targetPort: 8080
    - name: https
      port: 443
      protocol: TCP
      targetPort: 8443
  selector:
    app: istio-gateway
    istio: gateway

After

❯ helm template istio-gateway ./chart | yq 'select(.kind == "Service")'

# Source: gateway/charts/upstream/templates/service.yaml
apiVersion: v1
kind: Service
metadata:
  name: istio-gateway
  namespace: default
  labels:
    app.kubernetes.io/name: istio-gateway
    app.kubernetes.io/managed-by: "Helm"
    app.kubernetes.io/instance: "istio-gateway"
    app.kubernetes.io/part-of: "istio"
    app.kubernetes.io/version: "1.25.1"
    helm.sh/chart: upstream-1.25.1
    app: istio-gateway
    istio: "ingressgateway"
    "istio.io/dataplane-mode": "none"
  annotations: {}
spec:
  type: LoadBalancer
  ports:
    - name: tcp-status-port
      port: 15021
      protocol: TCP
      targetPort: 15021
    - name: http2
      port: 80
      protocol: TCP
      targetPort: 8080
    - name: https
      port: 443
      protocol: TCP
      targetPort: 8443
  selector:
    app: istio-gateway
    istio: "ingressgateway"

Diff

@@ -12,7 +12,7 @@
     app.kubernetes.io/version: "1.25.1"
     helm.sh/chart: upstream-1.25.1
     app: istio-gateway
-    istio: gateway
+    istio: "ingressgateway"
     "istio.io/dataplane-mode": "none"
   annotations: {}
 spec:
@@ -32,4 +32,4 @@
       targetPort: 8443
   selector:
     app: istio-gateway
-    istio: gateway
+    istio: "ingressgateway"

Linked Issue

#38 (closed)

Upgrade Notices

N/A