Add SSO checks before using auth information
General MR
Summary
Fixes an issue that appears when overriding the cr to include the auth type for openid and not turning on sso.
kiali:
enabled: true
values:
cr:
spec:
auth:
strategy: "openid"
This caused downstream resources to assume that values existed, when they did not due to sso being disabled.
Relevant logs/screenshots
Log Error
message: 'Helm install failed for release kiali/kiali-kiali with chart kiali@1.89.0-bb.0: template: kiali/templates/bigbang/ssoServiceEntry.yaml:7:50: executing "kiali/templates/bigbang/ssoServiceEntry.yaml" at <.Values.cr.spec.auth.openid.issuer_uri>: nil pointer evaluating interface {}.issuer_uri'
Linked Issue
No issue linked. Found as part of testing changes related to this issue in Nexus Repository Manager.
Upgrade Notices
N/A
Edited by Christopher Kyle Galloway
Merge request reports
Activity
assigned to @kylegalloway-seed
added statusreview label
requested review from @kipten, @kylegalloway-seed, @lgomez2, @ronwerth, @stephen.galamb, and @wyatt.fry
requested review from @dpritchettrm and @michaelmartin
added skip-bb-mr label
mentioned in merge request big-bang/bigbang!5045 (merged)
mentioned in commit dbe12c05
Please register or sign in to reply