Node selector fix
General MR
Summary
Added additional value to allow defender to have its own value for node selector instead of using the current node selector for twistlock console. Also updated the helm template to translate it properly as it was previously getting dumped into the secret as map[key:value] which breaks the deployment of defender.
Relevant logs/screenshots
Validated it functions when specifying a node selector for twistlock and a different one for defender:
Relates issue: #87 (closed)
Merge request reports
Activity
added kindbug statusdoing labels
added statusreview label and removed statusdoing label
- Resolved by Ryan Garcia
To test use the following values for twistlock values in a local development environment (will have to use a valid license):
nodeSelector: node-type: "twistlock" console: persistence: size: 256Mi localVolumeUpgrade: true license: <Will Have to use internal license to validate> defender: nodeSelector: node-type: "defender"
Prior to deployment make sure to label one or more nodes so they can get scheduled. The labels can be different or the same, it shouldn't matter either way so long as at least one node has it.
I'm not sure if this should be seen as a breaking change as defender was previously just using the same nodeSelector as twistlock console. However, that portion was never set up properly so it would have never worked.
changed milestone to %2.18.0
- Automatically resolved by Jimmy Bourque
- Resolved by Ryan Garcia
Changes all look good, just since Twistlock isn't based on an upstream chart let's bump the minor version for this tag
added priority4 statusdoing labels and removed statusreview label
assigned to @jimmy.bourque
added statusreview label and removed statusdoing label
- Resolved by Ryan Garcia