Add support for postRenderers: in wrapped packages

Feature Request

Why

At the moment, modifying the spec of a git repo for a wrapped package is not possible with something like the example below since postRenderers: are not yet supported in wrapped packages leaving this to be a manual task.

packages:
  podinfo:
    enabled: true
    git:
      repo: https://my.git.repo.com/podinfo/podinfo.git
      branch: dev
      path: path/to/podinfo
    postRenderers:
      - kustomize:
        patchesStrategicMerge:
        - kind: GitRepository
          apiVersion: source.toolkit.fluxcd.io/v1
          metadata:
            name: podinfo
            namespace: podinfo
          spec:
            secretRef:
              name: private-git

Proposed Solution

Update the helpers template of the wrapper package to add support as suggested here.

added triage-kind label

added community-contribution label

added triage-priority label

set weight to 3

added kindfeature priority4 wrapper labels

changed iteration to Big Bang Iterations Dec 12, 2023 - Dec 25, 2023

removed triage-kind label

removed triage-priority label

removed iteration Big Bang Iterations Dec 12, 2023 - Dec 25, 2023

changed iteration to Big Bang Iterations Dec 26, 2023 - Jan 8, 2024

added teamTools & Automation label

assigned to @seanthomas007

added statusdoing label

@jfoster are you familiar what modifying a "wrapped" package means? or where to start learning about this

A post-renderer can be any executable that accepts rendered Kubernetes manifests on STDIN and returns valid Kubernetes manifests on STDOUT. It should return an non-0 exit code in the event of a failure. This is the only "API" between the two components.

removed iteration Big Bang Iterations Dec 26, 2023 - Jan 8, 2024

changed iteration to Big Bang Iterations Jan 9, 2024 - Jan 22, 2024

unassigned @seanthomas007

removed statusdoing label

removed iteration Big Bang Iterations Jan 9, 2024 - Jan 22, 2024

changed iteration to Big Bang Iterations Jan 23, 2024 - Feb 5, 2024

removed weight

Please reweight if this is picked up and we know how long it will take to complete.

changed iteration to Big Bang Iterations Feb 6, 2024 - Feb 19, 2024

removed iteration Big Bang Iterations Jan 23, 2024 - Feb 5, 2024

removed iteration Big Bang Iterations Feb 6, 2024 - Feb 19, 2024

changed iteration to Big Bang Iterations Feb 20, 2024 - Mar 4, 2024

removed iteration Big Bang Iterations Feb 20, 2024 - Mar 4, 2024

changed iteration to Big Bang Iterations Mar 5, 2024 - Mar 18, 2024

removed iteration Big Bang Iterations Mar 5, 2024 - Mar 18, 2024

changed iteration to Big Bang Iterations Mar 19, 2024 - Apr 1, 2024

removed iteration Big Bang Iterations Mar 19, 2024 - Apr 1, 2024

changed iteration to Big Bang Iterations Apr 2, 2024 - Apr 15, 2024

changed iteration to Big Bang Iterations Apr 16, 2024 - Apr 29, 2024

removed iteration Big Bang Iterations Apr 2, 2024 - Apr 15, 2024

removed iteration Big Bang Iterations Apr 16, 2024 - Apr 29, 2024

changed iteration to Big Bang Iterations Apr 30, 2024 - May 13, 2024

assigned to @nicole.dupree

removed iteration Big Bang Iterations Apr 30, 2024 - May 13, 2024

changed iteration to Big Bang Iterations May 14, 2024 - May 27, 2024

removed iteration Big Bang Iterations May 14, 2024 - May 27, 2024

changed iteration to Big Bang Iterations May 28, 2024 - Jun 10, 2024

It's not exactly the same as the package chart, but have you tried

package:
  PKG_NAME:
    wrapper: true
    flux:
      postRenderers: { .... }

... That looks like it would probably do what you want

The wrapper chart allows for arbitrary flux configuration injection via that flux key

That map will get injected at the HelmRelease.spec level the same way the postRenderers are injected in the package chart

@kipten can you confirm whether this addresses your needs?

removed iteration Big Bang Iterations May 28, 2024 - Jun 10, 2024

changed iteration to Big Bang Iterations Jun 11, 2024 - Jun 24, 2024

set weight to 5

added statusdoing label

removed weight of 5

removed statusdoing label

removed iteration Big Bang Iterations Jun 11, 2024 - Jun 24, 2024

changed iteration to Big Bang Iterations Jun 25, 2024 - Jul 8, 2024

mentioned in merge request big-bang/bigbang!4620 (merged)

For this issue, the linked MR completes the requested work of enabling post renderers in the wrapper chart by defining them in the values, as follows:

packages:
  podinfo:
    enabled: true
    git:
      repo: https://my.git.repo.com/podinfo/podinfo.git
      branch: dev
      path: path/to/podinfo
    wrapper:
      enabled: true
      # These post renderers are applied to wrapper resources for this package
      postRenderers:
        - kustomize:
            patchesStrategicMerge:
              - [PATCH OBJECT]
    # These post renderers are applied to package resources
    postRenderers:
      - kustomize:
          patchesStrategicMerge:
            - [PATCH OBJECT]

HOWEVER This change does not enable, specifically, modifying GitRepository resources for either the package or the wrapper charts, because the GitRepository resources are created by the bigbang chart. Andrew has outlined a workaround for modifying flux configuration above and, in the absence of further communication, it would appear that a combination of this workaround and the addition of wrapper post renderers satisfies the requirements of this issue.

added statusreview label

closed with merge request big-bang/bigbang!4620 (merged)

mentioned in commit big-bang/bigbang@f6b50c55