PR for four P1 Theme Fixes/QoL Improvements
Handful of changes to consider for the P1 KC theme. Sorry, I don't have permissions to make a pull request, so I'll do my best to describe the changes.
1. Login page QoL Improvement for Mobile Users
Current | Proposed |
---|---|
Real screenshots from a Samsung S10+
Required code changes
- Update theme.properties, add:
meta=viewport==width=device-width,initial-scale=1
- Update new-ui.css, add the following media queries to prevent a colossal-logo for mobile users:
/* Max-width based off of bootstrap.css */
@media (max-width: 575.98px) {
.card-header.branding.row {
flex-wrap: nowrap;
}
.card-header.branding.row div:nth-child(2) {
max-width: 0;
}
}
/* Max-width based off testing */
@media (max-width: 300px) {
.card-header.branding.row {
flex-wrap: wrap;
}
}
navbar
hiding content on /account
pages
2. Fix Problem | Solution |
---|---|
Required code change
- Update new-ui.css, add the following:
/* Overrides bootstrap.css config */
.navbar.fixed-top {
position: sticky;
}
/account
pages
3. Fix QR code setup for Issue with a missing reference to totpStep2Note
template text.
Required code change
Problem | Solution |
---|---|
- Update message_en.properties, add:
totpStep2Note=Note: The QR code changes every time Submit is clicked and must be rescanned for each attempt.
-> INB4, this is not an issue for QR code setup during registration, the messages_en.properties
file under /login
is setup correctly.
4. (since you're already in there) Add left/right padding to QR code secret key
Happy | Glad |
---|---|
Required code change
- Update new-ui.css, update
#kc-totp-secret-key
:
#kc-totp-secret-key {
/* ... */
padding: 10px 5px;
}
Thanks!
Ducky
Edited by Jean-Luc Duckworth