Improvements to docker tag artifact caching fixes (!1534) · Merge requests · Iron Bank / ironbank-pipeline

Description

There were a couple issues in the original docker-tag-sha-validation MR (!1470 (closed)) that this MR addresses, to be merged back into that branch.

If a container artifact cache miss took place, the cache was cleared but the artifact was not then redownloaded. This would result in an immediate failure. This resolves that by switching the elif change back to if.
For container artifacts, delete_checksum was changed to delete_manifest and validate_checksum was changed to validate_manifest. This necessitated artifact type checks in various places in the code to call the right method depending on if the artifact was a container artifact or file artifact. In one place, the old AbstractContainerArtifact.delete_checksum method was still being called even though it didn't exist anymore. I've simplified all this by adding a common validate_cache method and delete_artifact_and_cache method to AbstractArtifact, so we no longer need artifact type checks in various places to know which method to call for cache validation and for artifact / cache deletion.
self.authfile was being passed into Skopeo, but self.authfile did not exist. I added it to the AbstractContainerArtifact class to mirror how its set on the ContainerArtifact class.
I removed some of the debug printing to print out files that didn't seem to be used anywhere, just to clean things up.
I cleaned up the code_checker to remove the exclusion of downloader.py.

Risk

This is being merged into the original docker-tag-sha-validation MR so merging this is low risk. Once that MR merges though, the risk to the pipeline is artifacts being cached incorrectly somehow.