Fix upgrade job
The argocd upgrade job was failing in Big Bang CI
Needed to remove the .Values.istio.injection from the conditional wrapped around the logic for killing the istio sidecar container
This value isn't present in the argocd chart, and was causing it to not render out and execute, causing the istio sidecar to stick around and the job to not complete, causing the helm release to fail.
Here's the pipeline now with the job running and terminating successfully - https://repo1.dso.mil/platform-one/big-bang/bigbang/-/pipelines/1084410
Merge request reports
Activity
assigned to @lucas.rodriguez
added statusdoing label
added 1 commit
- 2f013a01 - Update changelog, remove non-existent helm template value from upgrade job,...
added statusreview label and removed statusdoing label
requested review from @BrandenCobb and @micah.nagel
32 32 kubectl annotate --overwrite crd $crd meta.helm.sh/release-namespace="$YOUR_ARGOCD_NAMESPACE" 33 33 kubectl annotate --overwrite crd $crd meta.helm.sh/release-name="$YOUR_ARGOCD_RELEASENAME" 34 34 done 35 {{- if and .Values.istio.enabled (eq .Values.istio.injection "enabled") }} 35 {{- if and .Values.istio.enabled }} - Comment on lines -35 to +35
In my opinion since injection can be disabled on Argo (see here), we should leave this conditional as is and just make sure that we are passing down a value for it (also probably set a default of
"disabled"). @BrandenCobb thoughts? changed this line in version 7 of the diff
