UNCLASSIFIED - NO CUI

Remove Unused HAProxy Virtual Service

As part of the authservice deploy the haproxy virtual service is created:

NAME                              GATEWAYS                  HOSTS                                       AGE
authservice-haproxy-sso-haproxy   ["istio-system/public"]   ["haproxy.bigbang.dev"]                     1d

As far as I can tell it is unused. The alertmanager virtual service for example is configured to route traffic to the service:

spec:
  gateways:
  - istio-system/public
  hosts:
  - alertmanager.bigbang.dev
  http:
  - route:
    - destination:
        host: authservice-haproxy-sso.authservice.svc.cluster.local
        port:
          number: 8080

If this virtual service is not used, it shouldn't be created by default. Either this template should be removed or some logic should be added to make its creation configurable.