Removed promtail condition from Loki values check

General MR

Summary

Current BB values cause Loki to be deployed if Promtail is enabled, even when Loki itself is configured with enabled: false. There are use cases which require standalone deployments of Promtail, which makes this an undesirable behavior.

requested review from @rob.ferguson

assigned to @ablanchard

marked this merge request as ready

added 171 commits

• a5f6ff67...01cdb0fd - 170 commits from branch master
• 8f06084e - Removed promtail condition from Loki values check

Compare with previous version

added statusreview label

added community-contribution label

@ablanchard Can you elaborate on a scenario when promtail would be deployed without loki? This is not really a documented/required use case for that within BigBang at the moment.

One thing that will be necessary at minimum before this is good to go is adjusting conditionals across all the Loki files in this directory - https://repo1.dso.mil/platform-one/big-bang/bigbang/-/tree/bugfix/loki-deployment-conditionals/chart/templates/logging/loki

The single change you have made would still mean the gitrepo, hr, etc deploy, just without the values secret.

added 1 commit

• bc3f8498 - Removing additional promtail conditionals in the loki templates

Compare with previous version

added statusdoing label and removed statusreview label

@ablanchard This merge request is not marked as draft, if it is ready for review please add the label, statusreview.

added needs-labels label

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

@ablanchard This merge request has a failed pipeline and hasn't had any activity in a few days. If you have any questions or would like to give us feedback, please tag one of the codeowners in a comment on this merge request, or reach out to us on Mattermost.

added 672 commits

• bc3f8498...3972d201 - 666 commits from branch master
• 192c479b - Merge branch 'master' into bugfix/loki-deployment-conditionals
• 2ee6b9d1 - Adding fail condition if loki is disabled and no clients are provided to promtail
• 22380d09 - Adding conditional dependence on loki.enabled
• 6855f7c7 - Deploying the namespace if either loki OR promtail is enabled
• 0bd547ac - Correcting yaml path for promtail config clients
• c4b033fb - Adjusting nil protection

Compare with previous version

MR has been updated with the requested fail feature. Apologies on the delay.

Tested with the following scenarios/values.

Both enabled:

promtail:
  enabled: true

loki:
  enabled: true

-> SUCCESS

Loki disabled:

promtail:
  enabled: true

loki:
  enabled: false

-> FAILED with If Promtail is enabled and Loki is disabled, at least one client must be provided via '.Values.promtail.values.config.clients'

"Clients" provided:

promtail:
  enabled: true
  values:
    config:
      clients:
        - url: definitely.not.a.url

loki:
  enabled: false

-> "SUCCESS" (Promtail starts without issue, but logs obviously indicate a failure to push)

@ablanchard this merge request has been inactive for 30 days and is being labelled as stale. If this merge request is still required please take action by removing the stale label and commenting with an update, status, or justification. If this merge request is not required please close it or label it as delete-me. If no action is taken this merge request will be auto closed in 60 days.

added stale label

added 151 commits

• c4b033fb...a3ff7c29 - 150 commits from branch master
• 0735ac62 - Merge branch 'master' into bugfix/loki-deployment-conditionals

Compare with previous version

resolved all threads

added statusreview label and removed statusdoing label

requested review from @micah.nagel

Small style changes

resolved all threads

resolved all threads

added 1 commit

• 3cdf0662 - Apply 3 suggestion(s) to 3 file(s)

Compare with previous version

approved this merge request

enabled an automatic merge when the pipeline for 3cdf0662 succeeds

approved this merge request

canceled the automatic merge

merged

mentioned in commit 50f27b7b

changed milestone to %1.47.0

mentioned in issue #1450 (closed)