BULL-1495: Unit tests pass
Merge request reports
Activity
- Resolved by Michelle Tran
getting lots of errors like:
console.error node_modules/vue/dist/vue.runtime.common.dev.js:621 [Vue warn]: Invalid Component definition: found in ---> <Footer> <VApp> <App> <Root>
This is sometimes an indicator of missing components and could be hiding other errors.
- Resolved by Michelle Tran
The
npm run test:unit
command is failing with an exit code of 1. Appears to be due to the jest restrictions in package.json:Jest: Uncovered count for statements (520)exceeds global threshold (10) Jest: "global" coverage threshold for branches (50%) not met: 13.81% Jest: "global" coverage threshold for lines (50%) not met: 21.92% Jest: "global" coverage threshold for functions (50%) not met: 14.47%
Since the BULL-1495 story is to just get the unit tests passing (i.e. not about coverage), you can remove these lines from package.json. That should get
npm run test:unit
running successfully.
added 4 commits
-
f430e741...eab443ee - 2 commits from branch
master
- c6306627 - Merge branch 'master' into BULL-1495
- 9d49342a - BULL-1495 Updated xml svg declaration
-
f430e741...eab443ee - 2 commits from branch
mentioned in commit af1672dd