UNCLASSIFIED - NO CUI

Skip to content

Getting rid of withAPIMetrics, and using withAPIData

abhayashrestha requested to merge refactor-with-api-data into master
  • Getting rid of withAPIMetrics, and using withAPIData by making it reusable with hook injection abstraction.
  • Makes the higher order component withAPIData less fragile to change with react query changes for example.
  • Refactoring hooks in api to be hooks instead of some query function for react query.
  • Fixing logic with useMetrics hooks to take into account query cannot be enabled by using isIdle field from react query for loading logic.
  • dashboardType props should be a deprecated field as soon as createMetrics gets deprecated.
Edited by abhayashrestha

Merge request reports