Merge branch 'test' into 'master'

Updated bb values.yaml to have a global value for image pull policy for all core packages

Closes #897

See merge request platform-one/big-bang/bigbang!1136

chart/templates/clusterauditor/values.yaml

@@ -7,6 +7,9 @@ elasticsearch:
   imagePullSecrets:
     - name: private-registry
 
+image:
+  imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 monitoring:
   enabled: {{ .Values.monitoring.enabled }}
 

chart/templates/gatekeeper/values.yaml

@@ -4,17 +4,20 @@
 
 {{- define "bigbang.defaults.gatekeeper" -}}
 image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
   pullSecrets:
   - name: private-registry
 postInstall:
   labelNamespace:
     enabled: false
     image:
+      pullPolicy: {{ .Values.imagePullPolicy }}
       pullSecrets:
       - name: private-registry
 postUpgrade:
   cleanupCRD:
     image:
+      pullPolicy: {{ .Values.imagePullPolicy }}
       pullSecrets:
       - name: private-registry
 

chart/templates/istio/controlplane/values.yaml

@@ -25,6 +25,8 @@ networkPolicies:
   enabled: {{ .Values.networkPolicies.enabled }}
   controlPlaneCidr: {{ .Values.networkPolicies.controlPlaneCidr }}
 
+imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 {{- if .Values.istio.ingressGateways }}
 ingressGateways:
   istio-ingressgateway:

chart/templates/istio/operator/values.yaml

@@ -5,6 +5,8 @@
 {{- define "bigbang.defaults.istiooperator" -}}
 createNamespace: false
 
+imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 imagePullSecrets:
   - private-registry
 

chart/templates/jaeger/values.yaml

@@ -6,6 +6,9 @@
 imagePullSecrets:
   - name: private-registry
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+  
 # hostname is deprecated and replaced with domain. But if hostname exists then use it.
 {{- $domainName := default .Values.domain .Values.hostname }}
 hostname: {{ $domainName }}

chart/templates/kiali/values.yaml

@@ -10,6 +10,9 @@ domain: {{ $domainName }}
 
 openshift: {{ .Values.openshift}}
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
 istio:
   enabled: {{ .Values.istio.enabled }}
   kiali:
@@ -22,6 +25,8 @@ elasticsearch:
   enabled: {{ .Values.logging.enabled }}
 cr:
   spec:
+    deployment:
+      image_pull_policy: {{ .Values.imagePullPolicy }}
     server:
       web_port: "443"
     auth:

chart/templates/logging/eck-operator/values.yaml

@@ -8,6 +8,9 @@ license:
   keyJSON: |
     {{ .Values.logging.license.keyJSON | nindent 4 }}
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
 podAnnotations:
   sidecar.istio.io/inject: "true"
   traffic.sidecar.istio.io/includeInboundPorts: "*"

chart/templates/logging/elasticsearch-kibana/values.yaml

@@ -10,6 +10,8 @@ domain: {{ $domainName }}
 
 openshift: {{ .Values.openshift }}
 
+imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 istio:
   enabled: {{ .Values.istio.enabled }}
   kibana:

chart/templates/logging/fluentbit/values.yaml

@@ -11,6 +11,9 @@ elasticsearch:
 imagePullSecrets:
   - name: private-registry
 
+image:
+  pullPolicy: {{ .Values.imagePullPolicy }}
+
 networkPolicies:
   enabled: {{ .Values.networkPolicies.enabled }}
   controlPlaneCidr: {{ .Values.networkPolicies.controlPlaneCidr }}

chart/templates/monitoring/values.yaml

@@ -83,6 +83,7 @@ sso:
 
 grafana:
   image:
+    pullPolicy: {{ .Values.imagePullPolicy }}
     pullSecrets:
     - private-registry
 
@@ -127,6 +128,8 @@ grafana:
   {{- end }}
 
 prometheus-node-exporter:
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy }}
   serviceAccount:
     imagePullSecrets:
     - name: private-registry
@@ -138,6 +141,19 @@ prometheus-node-exporter:
   {{- end }}
 
 kube-state-metrics:
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy }}
   imagePullSecrets:
   - name: private-registry
+
+prometheusOperator:      
+  image:
+    pullPolicy: {{ .Values.imagePullPolicy }}      
+  admissionWebhooks:        
+    cleanupProxy:          
+      image:            
+        pullPolicy: {{ .Values.imagePullPolicy }}        
+    patch:           
+      image:            
+        pullPolicy: {{ .Values.imagePullPolicy }}
 {{- end -}}

chart/templates/twistlock/values.yaml

@@ -31,4 +31,8 @@ istio:
     gateways:
     - istio-system/{{ default "public" .Values.twistlock.ingress.gateway }}
 
+console:
+  image:
+    imagePullPolicy: {{ .Values.imagePullPolicy }}
+
 {{- end -}}

chart/values.yaml

@@ -109,6 +109,11 @@ networkPolicies:
   # Must be an IP CIDR range (x.x.x.x/x - ideally a /16 or /24 to include multiple IPs)
   nodeCidr: ""
 
+# -- Global ImagePullPolicy value for all packages
+# Permitted values are: None, Always, IfNotPresent 
+imagePullPolicy: IfNotPresent
+
+
 # ----------------------------------------------------------------------------------------------------------------------
 # Istio
 #

docs/guides/using_bigbang/image_pull_policy.md

 # ImagePullPolicy at Big Bang Level
 
-Big Bang is currently working to standardize the adoption of a global image pull policy so that customers can set a single value and have it passed to all packages. This work is not yet complete, but should allow customers easier control over their global pull policy.
+Big Bang is currently working to standardize the adoption of a global image pull policy so that customers can set a single value and have it passed to all packages.
 
-In the meantime we have begun to document the package overrides required in preparation for this change.
+The global image pull policy has been adopted in Big Bang for the core packages currently. In the Big Bang values.yaml file, a global parameter has been created to set the global image pull policy (`imagePullPolicy` in values) and it gets passed down to all core packages spec. The default value for this global policy is `IfNotPresent`.
+
+This work is not yet complete for addons, but should allow customers easier control over their global pull policy.
+
+We have also documented the package overrides required if you want to set a single package/pod with a different pull policy than the global.
 
 # ImagePullPolicy per Package