UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

Updated bb values.yaml to have a global value for image pull policy for all core packages

Merged Tawsif Siddiqui requested to merge test into master
All threads resolved!

Package Merge Request

Package Changes

  • Updated chart/values.yaml to include a global value for imagePullPolicy for all core packages (imagePullPolicy:{})
  • Updated the values.yaml for all the core package template/spec in BB to make sure the global value is passed down to all core packages
  • Updated image_pull_policy.md doc to show how to use the new global value for the core packages

For Issue

Closes #897 (closed)

Merge request reports

Merge request pipeline #591788 passed

Merge request pipeline passed for aeb376b3

Approved by

Merged by Micah NagelMicah Nagel 3 years ago (Dec 6, 2021 6:55pm UTC)

Merge details

  • Changes merged into master with 63e09c4b (commits were squashed).
  • Did not delete the source branch.

Pipeline #595535 passed

Pipeline passed for 63e09c4b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Micah Nagel
  • added 1 commit

    • 9994a792 - Updated the value for global imagePullPolicy

    Compare with previous version

  • Tawsif Siddiqui resolved all threads

    resolved all threads

  • added 1 commit

    • cdf9e449 - upated documentation for global image pull policy

    Compare with previous version

  • Deploying now to make sure this works. Changes look good to me, just a few docs suggestions.

  • added 1 commit

    • 16577471 - Fixed typo for imagePullPolicy

    Compare with previous version

  • added 1 commit

    • ab8e8833 - Updated docs for global image pull policy

    Compare with previous version

  • added 1 commit

    • cfe3e5ec - Doc updates for image pull policy

    Compare with previous version

  • Tawsif Siddiqui resolved all threads

    resolved all threads

  • Tawsif Siddiqui resolved all threads

    resolved all threads

  • added 1 commit

    • 55324c12 - Update to image pull policy doc

    Compare with previous version

  • requested review from @BrandenCobb and @ryan.j.garcia

  • Tested on my cluster, everything expected had pull policy set to whatever I set in my values :smile:

    kubectl get po -A -o go-template='{{range $pod := .items}}{{range $container := $pod.spec.containers}}{{$pod.metadata.name}}{{" : "}}{{$container.image}}{{" : "}}{{$container.imagePullPolicy}}{{"\n"}}{{end}}{{end}}'

    for your go-template enjoyment @BrandenCobb @ryan.j.garcia , podname : containerimage : pullpolicy. There are some pods we don't have this set on...jaeger, couple monitoring things, and maybe some others. Everything we know of overrides for works though.

    Edited by Micah Nagel
  • Micah Nagel approved this merge request

    approved this merge request

  • Micah Nagel added 9 commits

    added 9 commits

    Compare with previous version

  • Micah Nagel approved this merge request

    approved this merge request

  • Branden Cobb approved this merge request

    approved this merge request

  • Ryan Garcia approved this merge request

    approved this merge request

  • merged

  • Micah Nagel mentioned in commit 63e09c4b

    mentioned in commit 63e09c4b

  • Micah Nagel changed milestone to %1.23.0

    changed milestone to %1.23.0

  • Please register or sign in to reply
    Loading