Gitlab istio injection for jobs

Package Owner Merge Request

Complete istio injection for Gitlab jobs

• migration job
  closes https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/issues/109
• shared-secrets jobs
  closes https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/issues/110
• upgrade job.
  closes https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/issues/108
• delete the rolling-upgrade job

Fix gitlab-runner cypress tests to handle the upgrade pipeline

Package MRs

https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/98
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/96
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/99
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/merge_requests/102
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab-runner/-/merge_requests/38

Package Releases

https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/releases/5.3.1-bb.6
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/releases/5.3.1-bb.7
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/releases/5.3.1-bb.8
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab/-/releases/5.3.1-bb.9
https://repo1.dso.mil/platform-one/big-bang/apps/developer-tools/gitlab-runner/-/releases/0.33.1-bb.5

chart/templates/gitlab/values.yaml

@@ -12,6 +12,7 @@ openshift: {{ .Values.openshift }}
 
 istio:
   enabled: {{ .Values.istio.enabled }}
+  injection: {{ dig "istio" "injection" "enabled" .Values.addons.gitlab }}
   gitlab:
     gateways:
     - istio-system/{{ default "public" .Values.addons.gitlab.ingress.gateway }}
@@ -46,12 +47,6 @@ registry:
   {{- end }}
 {{- end }}
 
-{{- if .Values.istio.enabled }}
-shared-secrets:
-  annotations:
-    sidecar.istio.io/inject: "false"
-{{- end }}
-
 gitlab:
   {{- if .Values.addons.gitlab.objectStorage.endpoint }}
   task-runner:
@@ -75,18 +70,13 @@ gitlab:
     annotations: 
       iam.amazonaws.com/role: {{ .Values.addons.gitlab.objectStorage.iamProfile }}
   {{- end }}
-
-  {{- if .Values.istio.enabled }}
-  migrations:
-    annotations:
-      sidecar.istio.io/inject: "false"
-  {{- end }}
-  
+ 
 global:
 
   # added to help with Gitlab sub-chart configuration
   istio:
     enabled: {{ .Values.istio.enabled }}
+    injection: {{ dig "istio" "injection" "enabled" .Values.addons.gitlab }}
 
   hosts:
     domain: {{ $domainName }}