Enable specifying a secret for flux git creds
All threads resolved!
All threads resolved!
Add entrypoints into charts values.yaml
for (in order):
- using an existing secret for git credentials
- create
git-credentials
from user definedusername
/password
- create
git-credentials
from user definedprivateKey
/publicKey
/knownHosts
if none of the above are specified, repositories will assume unauthenticated access
Edited by joshwolf
Merge request reports
Activity
- Resolved by joshwolf
I think these sort of flags can/should be implemented with the following in mind:
- global value defaulting to empty
- global value passed into each implementation
- optional implementation value to overwrite global
what that looks like in practice:
# values.yaml gitCreds: foo # package/gitrepository.yaml {{- if .Values.gitCreds }} secretRef: {{ .Values.package.gitCreds | default .Values.gitCreds }} {{- end }}
added 32 commits
-
bb99640d...38268b90 - 30 commits from branch
master
- 1bca14a7 - Merge branch 'master' into feature/enable-git-creds
- e8367b70 - add entrypoints in values.yaml for user defined git credentials, existing secret, or nothing
-
bb99640d...38268b90 - 30 commits from branch
- Resolved by joshwolf
- Resolved by joshwolf
The only thing I think we should add is a check in the template to make sure just ONE of the three are set:
- secret
- login
- ssh key
i can imagine a scenario where someone accidentally adds too much
added 1 commit
- 9ba468b1 - explicitly call out git credentials precedence
mentioned in commit 8ca9e0c0
Please register or sign in to reply