Support for Tolerations
Summary
Request to add the support of tolerations as we're looking to scale down the PB padawan nodes and move mattermost to a specific node pool.
Steps to reproduce
Current chart doesn't support tolerations.
What is the current behavior?
We can't assign a pod to a specific node pool/workload.
What is the expected behavior?
Able to schedule the mattermost pod on a node with tolerated taint.
Relevant logs and/or screenshots
N/A
Possible fixes
Update the mattermost.yaml template to support tolerations.
Spoke to @michaelmcleroy and said this could be done.
AC:
- Add templating to allow this chart to support taints+tolerations via the mattermost custom resource
-
Bump version in
chart/Chart.yaml
andCHANGELOG.md
- Re-generate README
- Create Merge Request into BigBang with new package tag that includes above additions
-
Designs
- Show closed items
Blocks
- big-bang/bigbang #6502
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Michael McLeroy changed milestone to %1.15.0
changed milestone to %1.15.0
- Michael McLeroy changed iteration to Big Bang Iterations Aug 10, 2021 - Aug 23, 2021
changed iteration to Big Bang Iterations Aug 10, 2021 - Aug 23, 2021
- Michael McLeroy unassigned @michaelmcleroy
unassigned @michaelmcleroy
- Jason Krause set weight to 3
set weight to 3
- Jason Krause changed milestone to %1.16.0
changed milestone to %1.16.0
- Jason Krause changed milestone to %1.15.0
changed milestone to %1.15.0
- Jason Krause changed milestone to %1.16.0
changed milestone to %1.16.0
- Jason Krause changed iteration to Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
changed iteration to Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
Currently no upstream support. Opened ticket: https://github.com/mattermost/mattermost-operator/issues/237
- Jason Krause removed iteration Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
removed iteration Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
- Jason Krause changed milestone to %1.15.0
changed milestone to %1.15.0
- Jason Krause removed milestone %1.15.0
removed milestone %1.15.0
- Micah Nagel changed milestone to %1.16.0
changed milestone to %1.16.0
- Micah Nagel changed iteration to Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
changed iteration to Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
- Micah Nagel removed iteration Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
removed iteration Big Bang Iterations Aug 24, 2021 - Sep 6, 2021
- Micah Nagel removed milestone %1.16.0
removed milestone %1.16.0
- Micah Nagel added statusblocked label
added statusblocked label
- Branden Cobb added teamXForce label
added teamXForce label
- Micah Nagel removed weight
removed weight
- Micah Nagel set weight to 2
set weight to 2
- Contributor
Upstream changes are in master but still waiting on a release of the new operator version.
- Ryan Thompson added priority6 label
added priority6 label
- Micah Nagel removed statusblocked label
removed statusblocked label
- Contributor
No longer blocked, upstream update is in IB and package MR being worked - should make it into 1.20.
- Ryan Thompson changed iteration to Big Bang Iterations Nov 30, 2021 - Dec 13, 2021
changed iteration to Big Bang Iterations Nov 30, 2021 - Dec 13, 2021
- Ryan Thompson changed milestone to %1.23.0
changed milestone to %1.23.0
- Ryan Thompson added Good First Issue label
added Good First Issue label
- Ryan Garcia changed the description
Compare with previous version changed the description
- Jennifer Kays assigned to @jennifer.kays
assigned to @jennifer.kays
- Jennifer Kays added statusdoing label
added statusdoing label
- Jennifer Kays created merge request !78 (merged) to address this issue
created merge request !78 (merged) to address this issue
- Jennifer Kays mentioned in merge request !78 (merged)
mentioned in merge request !78 (merged)
- Contributor
Collapse replies - Contributor
Note: I did not see the error Mark mentioned. Instead my Mattermost pod was just being blocked by the taint.
- Contributor
Toleration code is working. Just needed to pass the toleration values for mattermost-operator, so mattermost could launch.
- Jennifer Kays marked the checklist item Add templating to allow this chart to support taints+tolerations via the mattermost custom resource as completed
marked the checklist item Add templating to allow this chart to support taints+tolerations via the mattermost custom resource as completed
- Jennifer Kays marked the checklist item Bump version in
chart/Chart.yaml
andCHANGELOG.md
as completedmarked the checklist item Bump version in
chart/Chart.yaml
andCHANGELOG.md
as completed - Jennifer Kays marked the checklist item Re-generate README as completed
marked the checklist item Re-generate README as completed
- Jennifer Kays added statusreview label and removed statusdoing label
added statusreview label and removed statusdoing label
- Contributor
Left small comments on the MR:
- versioning needs to be fixed since this is a BB owned/built helm chart (on these we do a standard semver update and then always append
-bb.0
rather than bumping the bb version. - one of the readme values needs manual intervention to escape a character
- versioning needs to be fixed since this is a BB owned/built helm chart (on these we do a standard semver update and then always append
- Micah Nagel added statusdoing label and removed statusreview label
added statusdoing label and removed statusreview label
- Micah Nagel added statusreview label and removed statusdoing label
added statusreview label and removed statusdoing label
- Micah Nagel mentioned in commit 0dd194dc
mentioned in commit 0dd194dc
- Micah Nagel closed with merge request !78 (merged)
closed with merge request !78 (merged)
- Jennifer Kays marked the checklist item Create Merge Request into BigBang with new package tag that includes above additions as completed
marked the checklist item Create Merge Request into BigBang with new package tag that includes above additions as completed
- Jennifer Kays marked the checklist item
as completedmarked the checklist item
as completed