UNCLASSIFIED - NO CUI

Skip to content
Snippets Groups Projects

#124: Fix regression of istio authorization policy label matching on 6.0.3-bb.1

Merged #124: Fix regression of istio authorization policy label matching on 6.0.3-bb.1
All threads resolved!
Merged Andrew Kesterson requested to merge 6.0.3-bb.1_bugfix_istio_applabels into main
All threads resolved!

General MR

Summary

When upgrading the chart for minio 6.0.3 we removed the default app: minio selector on istio authorization policies for bigbang. This resulted in RBAC failures when istio hardening was enabled. Since neither my manual testing or the package pipeline testing enabled istio hardening, we didn't discover this until 6.0.3-bb.1 was approved and hit the bigbang mergeback pipeline.

Relevant logs/screenshots

Passing test with istio hardening enabled

# Values
istio:
  enabled: true
  # ... snip ....
  values:
    hardened:
      enabled: true
# ... snip ....
addons:
  minio:
    enabled: true
    git:
      tag: ""
      branch: "6.0.3-bb.1_bugfix_istio_applabels"    
    values:
      istio:
        enabled: true
# ... snip ....

  Running:  01-minio-login.spec.cy.js                                                       (1 of 1)


  Minio Login
    ✓ Check Minio Login (3969ms)


  1 passing (7s)


  (Results)

  ┌────────────────────────────────────────────────────────────────────────────────────────────────┐
  │ Tests:        1                                                                                │
  │ Passing:      1                                                                                │
  │ Failing:      0                                                                                │
  │ Pending:      0                                                                                │
  │ Skipped:      0                                                                                │
  │ Screenshots:  0                                                                                │
  │ Video:        true                                                                             │
  │ Duration:     7 seconds                                                                        │
  │ Spec Ran:     01-minio-login.spec.cy.js                                                        │
  └────────────────────────────────────────────────────────────────────────────────────────────────┘


  (Video)

  -  Started compressing: Compressing to 35 CRF
  -  Finished compressing: 3 seconds

  -  Video output: /test/cypress/videos/01-minio-login.spec.cy.js.mp4

Prior to this change, the cypress test fails with 403 forbidden using the same values.

Linked Issue

#124 (closed)

Upgrade Notices

N/A

Merge request reports

Merge request pipeline #3614121 passed

Merge request pipeline passed for 731ed7d1

Merged by Michael MartinMichael Martin 7 months ago (Sep 17, 2024 5:40pm UTC)

Loading

Pipeline #3614141 passed

Pipeline passed for f41c50e7 on main

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Andrew Kesterson removed review request for @akesterson

    removed review request for @akesterson

  • Michael Martin approved this merge request

    approved this merge request

  • Michael Martin resolved all threads

    resolved all threads

  • added 1 commit

    • 731ed7d1 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Michael Martin reset approvals from @michaelmartin by pushing to the branch

    reset approvals from @michaelmartin by pushing to the branch

  • Michael Martin approved this merge request

    approved this merge request

  • Michael Martin mentioned in commit f41c50e7

    mentioned in commit f41c50e7

  • mentioned in merge request big-bang/bigbang!5090 (closed)

  • Please register or sign in to reply
    Loading