Add service monitor to Alloy/values.yaml

Package Merge Request

Package Changes

Enable the service monitors for alloy as well as configure the tls config with scheme=https through the postrenderers since the upstream override charts don't allow changes to scheme without affecting inter-deployment traffic since it isn't configured for istio peer istio convoy.

Package MR

N/A

For Issue

Closes big-bang/product/packages/alloy#83 (closed)

Upgrade Notices

N/A

changed milestone to %2.50.0

added alloy statusreview teamObservability labels

requested review from @michaelmartin, @andrewshoell, @chris1, and @troymobley

assigned to @kliu

mentioned in merge request !5867 (closed)

mentioned in merge request big-bang/product/packages/alloy!85 (merged)

added 1 commit

• 265eacba - removed receiver

Compare with previous version

resolved all threads

added 1 commit

• eb9ca941 - corrected sp for comment

Compare with previous version

approved this merge request

changed the description

unapproved this merge request

@kliu some suggestions. I think we're using (include "istioEnabled" . ) in several logic statements. And, I think we're using it incorrectly. As written like that, it will always evaluate to true. We're going to need to fix this in multiple areas.

I tested and suggest these changes:

At the top of the helmRelease, define this:

{{- $isStrictIstio := and (eq (include "istioEnabled" .) "true") (eq (dig "istio" "mtls" "mode" "STRICT" .Values.addons.alloy.values) "STRICT") -}}

For the logic block, do this:

  {{- toYaml $fluxSettingsAlloy | nindent 2 }}
  {{- if or .Values.addons.alloy.postRenderers (and .Values.monitoring.enabled $isStrictIstio ) }}
  postRenderers:
  {{- if and .Values.monitoring.enabled $isStrictIstio }}
  {{- include "alloy.istioPostRenderers" . | nindent 4 }}
  {{- end }}
  {{- with .Values.addons.alloy.postRenderers }}
  {{- toYaml . | nindent 4 }}
  {{- end }}
  {{- end }}

As I tested this, the behavior works as expected with enabling and disabling monitoring and/or istio and adding in a custom .Values.addons.alloy.postRenderers

If you can double-check that, we can alert the team that (include "istioEnabled" . ) in a logic statement will need to be fixed.

requested review from @chris.oconnell

added 1 commit

• 99d5dc24 - updated istio peer auth logic

Compare with previous version

resolved all threads

resolved all threads

approved this merge request

verified postRenderers come into the helmRelease based on what's enabled/defined.

merged

mentioned in commit 4a7f3ff6