Update virtualservice.yaml

Optionally allows for the definition of multiple virtualservice endpoints in Values.istio.gitlab.hosts. Default VS hostname is still Values.global.hosts.gitlab.name if no istio hostnames are provided.

closes #43 (closed)

Iron Bank still has to support the dsop.io hostname in addition to dso.mil, including registry.dsop.io. To accomplish this, we added both hostnames to the registry's VirtualService.

Additionally, for testing and blue/green migration to our new cluster, we wanted to make our GitLab instance listen on an alternate hostname that we could access and test before we switch over DNS.

Currently this chart does not allow providing a list of hostnames to be used in the VirtualService. This change allows overriding the hosts but still defaults to Values.global.hosts.*.name if no istio hostnames are provided

Hey guys, i just now noticed this MR. I might have seen it sooner if you had started with a Gitlab issue. I am planning a Gitlab release next week to be included in the BigBang 1.16.0 release on September 10. I will try to work this into the Gitlab release.

I do see a problem. The Gitlab chart does not support a list for hostnames

istio:
  # Toggle istio integration
  enabled: false
  gitlab:
    # Toggle vs creation
    enabled: true
    annotations: {}
    labels: {}
    gateways:
      - istio-system/main
    # hosts:  no hosts key supported here because the upstream chart has global.hosts

This is because the upstream chart has
global.hosts.registry
global.hosts.gitlab
And they are maps, not a list.
But we can figure something out next week.

assigned to @seagren.tim

requested review from @kevin.wilder

There is a related BigBang issue
https://repo1.dso.mil/platform-one/big-bang/bigbang/-/issues/715

added gitlab label

added BB Customer Issues label

changed the description

@blake.burkhart - a question for better understanding. You would set the istio hosts with values overrides from the BigBang values? like this?

addons:
  gitlab:
    values:
      istio:
        gitlab:
          hosts:
          - code1.my.domain
          - code2.my.domain
        registry:
          hosts:
          - registry1.my.domain
          - registry2.my.domain

changed milestone to %1.16.0

@seagren.tim - FYI... i need to rebase your branch and then push some commits to it.

added 7 commits

• 0e7f0a88...7112fd70 - 6 commits from branch main
• 4710b5c3 - Update virtualservice.yaml

Compare with previous version

added 1 commit

• cb476527 - bump chart version

Compare with previous version

added 1 commit

• 4fb186c8 - update changelog

Compare with previous version

added 1 commit

• c5f09311 - prevent empty line

Compare with previous version

added 1 commit

• dd4cc9d0 - add comments to explain istio hosts key

Compare with previous version

resolved all threads

added statusdoing label

added statusreview label and removed statusdoing label

requested review from @ryan.j.garcia

resolved all threads

approved this merge request

mentioned in commit e548a8bc

merged