Merged Andrew Kesterson requested to merge 577th_enablement into master 3 weeks ago

General MR

Summary

This corrects 3 problems discovered while helping a recent customer onboard with the quickstart:

#2591 (closed) : Quickstart instructions are ambiguous regarding where some commands should be run, exactly what the big bang cluster will have running on it, and how to restart the process if cluster creation fails. Also calls out a known incompatibility with yq versions < 4.45.1.

#2592 (closed) : k3d-dev has a hardcoded reference to the ubuntu username in it, foiling some users

#2593 (closed) : quickstart.sh --destroy doesn't handle user provided arguments properly

Relevant logs/screenshots

Hardcoded ubuntu username reference

Before

quickstart.sh -U myusername
# ... snip ...
+ sudo usermod -aG docker ubuntu
usermod: user 'ubuntu' does not exist

After

quickstart.sh -U myusername
# ... snip ...
+ sudo usermod -aG docker myusername

quickstart processing --destroy

The --destroy flag is intended to completely destroy an instance, so the k3d-dev script can't actually process it on an instance it didn't create in AWS. But in this case it should fail gracefully, rather than failing with an error. This patch fixes the failure to be graceful and informative.

Before

$ bash quickstart.sh --destroy -H 192.168.1.1 -K ~/.ssh/demo.pem
An error occurred (UnauthorizedOperation) when calling the DescribeVpcs operation: You are not authorized to perform this operation. User:arn:aws:iam:*:user/* is not authorized to perform: ec2:DescribeVpcs because no identity-based policy allows the ec2:DescribeVpcs action
AWS account has no default VPC - please provide VPC_ID

After

$ bash quickstart.sh --destroy -H 192.168.1.1 -K ~/.ssh/demo.pem
The current instance may not have been provisioned by k3d-dev. It is probably not appropriate 
for k3d-dev to attempt to destroy it.
Nothing to do.